search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Refactor ACL handling #69

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Realized chown was going to be impossible to implement with mongo restrictions on changing a field twice in one query. Now the owner is added to the read acl immediately and stays there after a chown.

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will increase coverage by 0.06%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   90.32%   90.38%   +0.06%     
==========================================
  Files          12       12              
  Lines        1106     1113       +7     
==========================================
+ Hits          999     1006       +7     
  Misses         82       82              
  Partials       25       25
Impacted Files Coverage Δ
nodestore/interface.go 100% <100%> (ø) :arrow_up:
service/server.go 97.85% <100%> (ø) :arrow_up:
nodestore/mongostore.go 86.51% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b142d3...38859ce. Read the comment docs.