search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Don't prefix object names with slashes #80

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Amazon object names aren't prefixed in their examples, although it doesn't say not to do so: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html

Minio doesn't like leading slashes: https://github.com/minio/minio/issues/7717

codecov[bot] commented 5 years ago

Codecov Report

Merging #80 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   91.44%   91.41%   -0.03%     
==========================================
  Files          12       12              
  Lines        1250     1247       -3     
==========================================
- Hits         1143     1140       -3     
  Misses         82       82              
  Partials       25       25
Impacted Files Coverage Δ
filestore/s3.go 90.09% <100%> (-0.27%) :arrow_down:
core/core.go 98.94% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4affd...0a10389. Read the comment docs.