search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Docker build attempt 1 #89

Closed MrCreosote closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will decrease coverage by 0.8%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   91.09%   90.28%   -0.81%     
==========================================
  Files          12       13       +1     
  Lines        1291     1307      +16     
==========================================
+ Hits         1176     1180       +4     
- Misses         89      100      +11     
- Partials       26       27       +1
Impacted Files Coverage Δ
service/server.go 97.57% <ø> (ø) :arrow_up:
service/build.go 62.26% <0%> (-1.74%) :arrow_down:
auth/cache.go 0% <0%> (ø)
auth/kbase_provider.go 93.69% <0%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7910a9f...09fbccf. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          12       12           
  Lines        1291     1291           
=======================================
  Hits         1176     1176           
  Misses         89       89           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7910a9f...f6ee833. Read the comment docs.

MrCreosote commented 5 years ago

docker-compose up allows saving and getting files, confirming mongo & minio connections.

MrCreosote commented 5 years ago

@sychan ready for re-review / merge

MrCreosote commented 5 years ago

Codecov seems to have gotten confused, since no code files changed and yet it's complaining about coverage

sychan commented 5 years ago

Looks good