search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Check for valid MD5s #95

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Just use a wrapper struct for MD5 strings. That checks them at the source and ensures they're ok everywhere else.

This check is important to ensure Minio isn't running in S3 incompatibility mode.

codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.19%. The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #95     +/-   ##
=========================================
- Coverage   90.84%   90.65%   -0.2%     
=========================================
  Files          13       14      +1     
  Lines        1366     1381     +15     
=========================================
+ Hits         1241     1252     +11     
- Misses         95       97      +2     
- Partials       30       32      +2
Impacted Files Coverage Δ
filestore/interface.go 100% <ø> (ø) :arrow_up:
core/core.go 98.94% <ø> (ø) :arrow_up:
nodestore/interface.go 100% <100%> (ø) :arrow_up:
nodestore/mongostore.go 86.17% <100%> (+0.06%) :arrow_up:
core/values/values.go 100% <100%> (ø)
service/server.go 97.57% <100%> (ø) :arrow_up:
filestore/s3.go 87.39% <60%> (-2.7%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 673071a...ff5ccb8. Read the comment docs.