search

kbase / cdm-jupyterhub

CDM JupyterHub Images for Spark Execution on KBase Rancher
MIT License
2 stars 1 forks source link

add bashrc ext files #107

Closed Tianhao-Gu closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.27%. Comparing base (73d0ad5) to head (50d25a4). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ======================================= Coverage 44.27% 44.27% ======================================= Files 7 7 Lines 463 463 ======================================= Hits 205 205 Misses 258 258 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MrCreosote commented 1 month ago

Why the .ext file extensions? Is it something to do with this? https://docs.nersc.gov/environment/#dotfiles-and-customizing-your-environment

Tianhao-Gu commented 1 month ago

Why the .ext file extensions? Is it something to do with this? https://docs.nersc.gov/environment/#dotfiles-and-customizing-your-environment

yea. I copied the implementation idea from NERSC. But we could change the .ext to something our own. Our use case currently is much simpler. I will basically just use them as template files and create .bashrc and .bash_profile in users' home dir.

MrCreosote commented 1 month ago

Why have extensions at all then?

Tianhao-Gu commented 1 month ago

Why have extensions at all then?

To keep them different from .bashrc and .bash_profile. It's just a file extension that only makes sense to us and NERSC once had it too so I borrowed it.

MrCreosote commented 1 month ago

If you're using them as a template and making the actual files in the user home dir why do the have to have different file names?

Tianhao-Gu commented 1 month ago

If you're using them as a template and making the actual files in the user home dir why do the have to have different file names?

They don't have to be. They're just placeholders. Can you suggest you preferred file names for this PR approval? And I'll just update them accordingly.

MrCreosote commented 1 month ago

I would either do no extension at all, or if you expect them to be jinja templates or something, .tmpl

Tianhao-Gu commented 1 month ago

I would either do no extension at all, or if you expect them to be jinja templates or something, .tmpl

👍