search

kbase / cdm-jupyterhub

CDM JupyterHub Images for Spark Execution on KBase Rancher
MIT License
2 stars 1 forks source link

remove sparkmonitor #76

Closed Tianhao-Gu closed 2 months ago

Tianhao-Gu commented 2 months ago

Remove SparkMonitor based on feedback from the demo.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.76%. Comparing base (abf2812) to head (5d42a8e). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 48.76% 48.76% ======================================= Files 4 4 Lines 121 121 ======================================= Hits 59 59 Misses 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tianhao-Gu commented 2 months ago

Do you want to make this a toggle vs a straight removal? In the future users might be able to choose whether it's enabled or not if so

I think it's fine to remove it for now. If needed, we can easily reintroduce it later.