search

kbase / cdm-jupyterhub

CDM JupyterHub Images for Spark Execution on KBase Rancher
MIT License
1 stars 1 forks source link

setup jupyterhub config #78

Closed Tianhao-Gu closed 1 week ago

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.60%. Comparing base (a208fa7) to head (7e7cf1f). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/jupyterhub_config/custom_spawner.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== + Coverage 48.76% 49.60% +0.83% ========================================== Files 4 5 +1 Lines 121 125 +4 ========================================== + Hits 59 62 +3 - Misses 62 63 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tianhao-Gu commented 1 week ago

I don't really understand enough about how jupyterhub works to properly review this. What prevents user A from reading from or writing to user B's environment?

Upon logging in, we need to ensure user's home directory is properly created and permissioned which will be done by VirtualEnvSpawner class.