Closed jeff-cohere closed 9 months ago
Attention: 68 lines
in your changes are missing coverage. Please review.
Comparison is base (
44549b0
) 71.95% compared to head (b56fb34
) 72.84%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like Globus has discontinued support for Globus Connect Server v4 as of December 2023. This PR is affected because we test our Globus endpoints with some GCSv4 servers that had been made available by Globus for tutorial purposes but no longer seem to work (they return an error message saying "GCSv4 is no longer supported. Contact your sysadmin.").
I'll try to figure out another way to test our basic Globus endpoint features. We're going to be dealing with these kinds of externalities with DTS throughout the project, so minimizing them is worthwhile in any case.
This PR is larger than I wanted it to be, but I guess we're still in the throes of early development.
Points of interest:
manifest.json
file and uses its local endpoint to transfer the manifest to the destination endpoint.Root()
method in their interface, which tells you the root directory of their underlying file system. This turns out to be very helpful.TaskManager
type, bestowing the lifecycle-related stuff upon a "task" type. I hope the flow of control is a little simpler and more resiliant to concurrent requests.Work still to do (perhaps in later PRs):
Closes #29