kbase / dts

A data transfer service
https://kbase.github.io/dts/
MIT License
0 stars 0 forks source link

Flattened error checks and cleaned up code. #39

Closed jeff-cohere closed 8 months ago

jeff-cohere commented 8 months ago

Here's how the new error checking boilerplate is looking. I also broke up task.Update in the task manager, which was actually made easier by flattening the error checking.

Closes #38

codecov[bot] commented 8 months ago

Codecov Report

Attention: 315 lines in your changes are missing coverage. Please review.

Comparison is base (4b26e8d) 72.71% compared to head (4ee6dd9) 62.00%.

Files Patch % Lines
endpoints/globus/endpoint.go 54.64% 98 Missing and 24 partials :warning:
databases/jdp/database.go 28.42% 63 Missing and 5 partials :warning:
core/task_manager.go 69.38% 30 Missing and 15 partials :warning:
services/prototype.go 22.58% 15 Missing and 9 partials :warning:
databases/jdp/jamo.go 16.00% 18 Missing and 3 partials :warning:
auth/kbase_auth_server.go 45.16% 12 Missing and 5 partials :warning:
endpoints/local/endpoint.go 43.47% 9 Missing and 4 partials :warning:
config/config.go 50.00% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## =========================================== - Coverage 72.71% 62.00% -10.71% =========================================== Files 13 13 Lines 1616 1732 +116 =========================================== - Hits 1175 1074 -101 - Misses 364 526 +162 - Partials 77 132 +55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeff-cohere commented 8 months ago

Of course, in small code bases with lots of error checking, it's hard to get good test coverage. :-)