search

kbase / dts

A data transfer service
https://kbase.github.io/dts/
MIT License
0 stars 0 forks source link

Implemented task cancellation. #45

Closed jeff-cohere closed 7 months ago

jeff-cohere commented 7 months ago

I also fixed some glitches in the Globus transfer tests.

Closes #36

codecov[bot] commented 7 months ago

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (1e10656) 61.43% compared to head (1e7f10a) 62.72%. Report is 1 commits behind head on main.

Files Patch % Lines
tasks/tasks.go 56.19% 40 Missing and 6 partials :warning:
services/prototype.go 47.91% 22 Missing and 3 partials :warning:
endpoints/local/endpoint.go 56.25% 13 Missing and 8 partials :warning:
endpoints/globus/endpoint.go 74.64% 13 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== + Coverage 61.43% 62.72% +1.29% ========================================== Files 12 12 Lines 1893 2015 +122 ========================================== + Hits 1163 1264 +101 + Misses 578 575 -3 - Partials 152 176 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeff-cohere commented 7 months ago

Ah, you know, I haven't yet patched a cancellation endpoint into the service and tested it. That shouldn't take too long, though, and it should be independent of the code that's in so far. Stand by.

jeff-cohere commented 7 months ago

One thing remains now: to test the REST call to the service for task cancellation.

jeff-cohere commented 7 months ago

Okay, this PR's ready to go.

jeff-cohere commented 7 months ago

I've identified a case in which a task may be cancelled and its status may not be properly updated afterward, so I'm working on a fix. Should only affect one file, though.

jeff-cohere commented 7 months ago

Okay, sorry about the wobbles. Let's try this out. I'll turn my attention next to some code cleanup.