Closed jeff-cohere closed 7 months ago
Attention: 110 lines
in your changes are missing coverage. Please review.
Comparison is base (
1e10656
) 61.43% compared to head (1e7f10a
) 62.72%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ah, you know, I haven't yet patched a cancellation endpoint into the service and tested it. That shouldn't take too long, though, and it should be independent of the code that's in so far. Stand by.
One thing remains now: to test the REST call to the service for task cancellation.
Okay, this PR's ready to go.
I've identified a case in which a task may be cancelled and its status may not be properly updated afterward, so I'm working on a fix. Should only affect one file, though.
Okay, sorry about the wobbles. Let's try this out. I'll turn my attention next to some code cleanup.
I also fixed some glitches in the Globus transfer tests.
Closes #36