DATAUP-434 retry ADR3 review

kbase / execution_engine2

KBase Execution Engine

http://www.kbase.us/services/ee2

MIT License

0 stars 7 forks source link

DATAUP-434 retry ADR3 review #409

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

Oh whoops, I didn't see you'd marked this as ready for review and I was sure I'd marked it as draft earlier, so I remarked it. This just goes from one artificial branch to another, so merging it doesn't actually fix anything. Once everyone is g2g you'll have to copy the updated file from this branch into another new branch.

Or maybe retargeting to develop might work, not sure.

MrCreosote commented 3 years ago

Tests are failing again but presumably that's not due to the documentation changes here

MrCreosote commented 3 years ago

Oh right, I can't approve my own PR. LGTM though. Once @ialarmedalien and @briehl have approved I'd just make a new branch, copy this file into the branch, PR & merge