kbase / execution_engine2

KBase Execution Engine
http://www.kbase.us/services/ee2
MIT License
0 stars 7 forks source link

Don't toggle mongo collection instance variable #433

Closed MrCreosote closed 2 years ago

MrCreosote commented 2 years ago

Description of PR purpose/changes

The current MongoUtil implementation has one mongo_collection instance variable that can be set to either the jobs collection or the logs collection depending on which method was called last. Methods that don't explicitly choose the collection themselves will use the collection set by whichever method was most recently called, which might be the wrong collection.

This commit makes two separate variables and ensures the right collection is being used for each method. It also deletes a number of unused methods.

Jira Ticket / Github Issue

Testing Instructions

Dev Checklist:

Updating Version and Release Notes (if applicable)

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 4c75bda28352fafaa6f88a63da5efe7cfd4f5c54 into 18408b25510383b44025c9dde9cf4d4813977f52 - view on LGTM.com

new alerts: