Closed bio-boris closed 2 years ago
This pull request introduces 1 alert when merging 3b8885b315417a6e28c811a5b0d6a7a2813d2cda into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
new alerts:
This is probably caused by https://github.com/kbase/execution_engine2/pull/385
This PR is currently deployed on CI.. Now the job counts are correctly updating, and the link under "user job counts" actually goes to the right place as well.
Would it be too much trouble to split this into 2 PRs - one with all the formatting fixes and one with the actual bugfixes? It'd be a lot easier to review that way but I'll suck it up if it's going to be a pain
@MrCreosote the PR will fail without the formatting fixes for these other files.
I mean presumably PR#1 could contain the formatting fixes and PR#2 could contain the actual bugfix, right? No big deal though
This is probably caused by https://github.com/kbase/execution_engine2/pull/385
I took a look at 385 and I'm not sure how this caused the stats issue - it just didn't try and parse the app_id if there wasn't one...?
Yea that was my initial hypothesis but I don't think that was the case at all
This pull request fixes 4 alerts when merging deec86d9bbe47cb39061f1614d83b2dc0a4094ae into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging 9686c4ca79681d93f5abde454a54159776263b77 into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging d945fa4a4970eb8593736fba66043939def9383f into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging 0684fdb07734863c62560c762b4a7f2633af350c into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging 93bd15eae716ba41618af3d74647ced38a523807 into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging 763663e458a90b207356be6edacc87e61e656cd1 into 1414ddfa73df67353523ca692807554b7aa69b97 - view on LGTM.com
fixed alerts:
Description of PR purpose/changes
Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)