Support Windows KB-SDK

[sjyoo]

Requirements:

• Java 1.7 or up
• Docker Quickstart Terminal with Docker

[rsutormin]

@sjyoo: Hey Shinjae, I'm going to make some changes to your code. Don't you mind if I create PR to your fork?

[sjyoo]

No problems at all... please do it -SJ

On Wed, Jun 1, 2016 at 6:55 PM, Roman Sutormin notifications@github.com wrote:

@sjyoo https://github.com/sjyoo: Hey Shinjae, I'm going to make some changes to your code. Don't you mind if I create PR to your fork?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kbase/kb_sdk/pull/153#issuecomment-223149328, or mute the thread https://github.com/notifications/unsubscribe/AHj1rcKpUXn5TIR5ygETm0wLbwSSgRXFks5qHg39gaJpZM4IqeS- .

[sjyoo]

Also, I expected you may need to reorganize the materials... -SJ

On Wed, Jun 1, 2016 at 7:03 PM, Shinjae Yoo shinjae@gmail.com wrote:

No problems at all... please do it -SJ

On Wed, Jun 1, 2016 at 6:55 PM, Roman Sutormin notifications@github.com wrote:

@sjyoo https://github.com/sjyoo: Hey Shinjae, I'm going to make some changes to your code. Don't you mind if I create PR to your fork?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kbase/kb_sdk/pull/153#issuecomment-223149328, or mute the thread https://github.com/notifications/unsubscribe/AHj1rcKpUXn5TIR5ygETm0wLbwSSgRXFks5qHg39gaJpZM4IqeS- .

[rsutormin]

Here it is: https://github.com/sjyoo/kb_sdk/pull/1 Pay attention at last commit only. Other commits are just synchronization with last state of develop branch. Can you please make sure these changes work for you on Windows? I had no chance to check it unfortunately.

[sjyoo]

Hi Roman,

I'll merge it but I doubt it would work under Cygwin because the way cmd handling is specialized for Msys but since we decided to support only docker terminal or Msys, I guess it is fine...

I'll test it tomorrow early morning and make sure and then merge yours...

Thanks, -SJ

On Wed, Jun 1, 2016 at 7:34 PM, Roman Sutormin notifications@github.com wrote:

Here it is: sjyoo#1 https://github.com/sjyoo/kb_sdk/pull/1 Pay attention at last commit only. Other commits are just synchronization with last state of develop branch. Can you please make sure these changes work for you on Windows? I had no chance to check it unfortunately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kbase/kb_sdk/pull/153#issuecomment-223156017, or mute the thread https://github.com/notifications/unsubscribe/AHj1rXo6FIfT3_2iFuJIglOo0aJnmRbQks5qHhcYgaJpZM4IqeS- .

[rsutormin]

Yeah, I think we should change boolean isWindows = System.getProperty("os.name").startsWith("Windows"); to boolean isWindows = System.getProperty("os.name").toLowerCase().contains("win"); It should work in Cygwin as well.

[sjyoo]

@rsutormin, it works well and please proceed to merge this PR.