search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
27 stars 32 forks source link

[WIP] Allow configuration of auth service #191

Closed kkellerlbl closed 7 years ago

kkellerlbl commented 8 years ago

Support configuration of an auth service endpoint in the configuration file. The generated Service.pm will use the auth client library's default URL if not configured.

I've been testing this with my modifications to handle_service and it looks like it behaves okay. It'd be helpful to have other eyes on it as well.

This PR goes to a new branch of kb_sdk, so merging won't break anything. If it looks ok we can do another PR to develop.

kkellerlbl commented 8 years ago

Depends on https://github.com/kbase/auth/pull/31

kkellerlbl commented 8 years ago

We may also need to change the pointer for the auth submodule.

MrCreosote commented 8 years ago

@rsutormin should take a gander at this although it looks simple

kkellerlbl commented 8 years ago

Ping @rsutormin what do you think?

rsutormin commented 8 years ago

Sorry guys, I was busy lately. Do we support such config in python and java already? And what about tests?

kkellerlbl commented 8 years ago

I have not tried running Perl tests yet.

kkellerlbl commented 8 years ago

I want to run three different permutations of test.

  1. Current codebase
  2. These changes plus stock auth (should work, I think)
  3. These changes plus Perl auth client changes in auth/dev-perl_auth branch

So far test 1. runs for a long time, so I may need to kill it and start again tomorrow. 3. is having problems, and I need to track down exactly what they are. It's currently failing in testJavaAsyncService in AsyncDockerTest, which is odd because I didn't touch that code. It may be a different issue.

kkellerlbl commented 8 years ago

Please do not merge

kkellerlbl commented 8 years ago

Still need more time to fix tests. I'm closing till ready.

kkellerlbl commented 7 years ago

Please do not merge yet.

kkellerlbl commented 7 years ago

It's wrong anyway, there's a reference to one of my repos.