search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
27 stars 32 forks source link

Auth2 docs #263

Closed JamesJeffryes closed 7 years ago

JamesJeffryes commented 7 years ago

Primary updated the docs to discuss generation and use of a token rather than a password. If you think it's a bad idea for users to use a token from the narrative to be able to test, let me know and I'll rollback that commit.

Fixes PTV-306 https://kbase-jira.atlassian.net/browse/PTV-306

JamesJeffryes commented 7 years ago

Note: the text of test_local/readme.txt should probably be updated (or just removed) but I could not find it's source in the sdk

sychan commented 7 years ago

@MrCreosote These generally look good to me, can you review as well?

MrCreosote commented 7 years ago

@JamesJeffryes The test_local readme template is here: https://github.com/kbase/kb_sdk/blob/develop/src/java/us/kbase/templates/module_readme_test_local.vm.properties

MrCreosote commented 7 years ago

The build failure is a new one to me.

JamesJeffryes commented 7 years ago

@MrCreosote Do you think this could be a transient error? I replicated the changes on a new fork on my repo which passes https://travis-ci.org/JamesJeffryes/kb_sdk. Apparently I don't have the privileges to restart a build on this repo on Travis but that's what I'd be interested to try

MrCreosote commented 7 years ago

@JamesJeffryes

Do you think this could be a transient error?

yep, could be. If it were up to me I'd ignore it for now.

MrCreosote commented 7 years ago

@sychan Is there a reason you haven't merged this yet?