TASK-935: Callback server failhard

kbase / kb_sdk

Build and test new apps for the KBase platform

http://kbase.github.io/kb_sdk_docs

MIT License

27 stars 32 forks source link

TASK-935: Callback server failhard #269

Closed arfathpasha closed 6 years ago

arfathpasha commented 7 years ago

added new jar dependencies for power mockito testing. Specifically for mocking the static method CallbackServer.getCallbackUrl()
added a fix in ModuleTester and ModuleRunner
added a test for the failure case in ModuleTester using a mocked CallbackServer.getCallbackUrl()

Note: this PR is linked to corresponding PR in Jars repo containing new jar dependencies (which has now been merged)

MrCreosote commented 7 years ago

Is this ready for review?

arfathpasha commented 7 years ago

Yes. I learned that using merge is cleaner than using rebase when it comes to updating PRs with interim changes from others developers. The last merge commit in this PR is a merge from other developers' interim commits to the develop branch that you can ignore because these changes already exist in the develop branch.

jayrbolton commented 6 years ago

Closing this.. @MrCreosote let me know if you want me to keep this open.