search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
27 stars 32 forks source link

Change name of the base image that is built/used #304

Closed sychan closed 6 years ago

sychan commented 6 years ago

I ran the following all without error: make make sdkbase (with the new kb-sdk) kb-sdk init --example -l python -u sychan MyContigs5 kb-sdk test (against CI)

sychan commented 6 years ago

@scanon I'm guessing that we pushed kbase/kbase:sdkbase.latest to dockerhub as kbase/sdkbase:latest? I've gotten rid of the phantom image renaming and just push it to dockerhub as kbase/kbase:sdkbase.latest and pull it back down again.

MrCreosote commented 6 years ago 

~/localgit/kb_sdk$ make test
git submodule init
git submodule update

*snip*

     [exec] 0   us.kbase.tools.WorkspaceTools.GlobalArgs (covered=0/3)
     [exec] 0   us.kbase.tools.WorkspaceTools.HelpCommandArgs (covered=0/6)
     [exec] Common coverage: 72.4878(38217/52722)

BUILD SUCCESSFUL
Total time: 18 minutes 16 seconds
~/localgit/kb_sdk$ git log
commit e29f39ed467111aa60bdca74b3d45439d76e71c2
Author:  *snip*
Date:   Thu Feb 15 15:57:35 2018 -0800

    Modify entrypoint to pull from new image name
MrCreosote commented 6 years ago

This looks ok to me, but I'm not super knowledgeable about this chunk of the system. @scanon if you're happy go ahead and merge.

scanon commented 6 years ago

I think we should merge it.