search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
27 stars 32 forks source link

Sync up the changes from njs_wrapper for CallbackServerConfigBuilder … #317

Closed jayrbolton closed 6 years ago

jayrbolton commented 6 years ago

Sync up changes from an njs_wrapper PR (https://github.com/kbase/njs_wrapper/pull/113) for the duplicated code in in CallbackServerConfigBuilder and SubsequentCallRunner

sychan commented 6 years ago

Would Boris be a good person to review this as well?

jayrbolton commented 6 years ago

I'm going to investigate some of this code a little more (ie. DockerMountPoints).. I will close this PR for now so there's less stuff open

jayrbolton commented 6 years ago

I think this is worth merging so that the code doesn't diverge from njs_wrapper. @bio-boris can you review? I'm syncing up the changes on:

Which are duplicated between this repo and njs_wrapper.

I'm minimally adding params in these files:

So that everything still compiles.

I haven't figured out how to use the refData related variables more intelligently in this repo. This PR can just serve as a minimalistic compatibility update to prevent the two codebases from diverging.

jayrbolton commented 6 years ago

I'm going to double check that these files look exactly the same on NJS and here and then will merge to develop.