update default method ui spec

psdehal commented 5 years ago

pass input mapping by target property and delete the outdated output mapping

jayrbolton commented 5 years ago

So as discussed in person, I think we do want to leave the "workspace" parameter in the default spec for creating reports. I would vote to change it so we eliminate the "target_argument_postion" stuff (have only a single argument with params):

            "input_mapping": [
                {
                    "narrative_system_variable": "workspace",
                    "target_property": "workspace_name"
                },
                {
                    "input_parameter": "my_parameter",
                    "target_property": "my_parameter"
                }
            ],

psdehal commented 5 years ago

that makes sense to me.

On Thu, Oct 25, 2018 at 3:19 PM Jay R Bolton notifications@github.com wrote:

So as discussed in person, I think we do want to leave the "workspace" parameter in the default spec for creating reports. I would vote to change it so we eliminate the "target_argument_postion" stuff (have only a single argument with params):
        "input_mapping": [
            {
                "narrative_system_variable": "workspace",
                "target_property": "workspace_name"
            },
            {
                "input_parameter": "my_parameter",
                "target_property": "my_parameter"
            }
        ],
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbase/kb_sdk/pull/325#issuecomment-433224723, or mute the thread https://github.com/notifications/unsubscribe-auth/AH0y9HMD3pXmUpq-B_0KHoaVpQzHh0m9ks5uojjNgaJpZM4X2KvP .

JamesJeffryes commented 5 years ago

@jayrbolton This PR is superseded by #327

scanon commented 5 years ago

Let's close this off and go with #327

kbase / kb_sdk

update default method ui spec #325