search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
26 stars 32 forks source link

fix python3 import #342

Closed Tianhao-Gu closed 5 years ago

Tianhao-Gu commented 5 years ago

@JamesJeffryes @jayrbolton Hi guys, ConfigParser was renamed to configparser in Python3 https://docs.python.org/2/library/configparser.html#module-ConfigParser

JamesJeffryes commented 5 years ago

Where are you seeing these files used? I've always thought that they were no longer used

Tianhao-Gu commented 5 years ago

@JamesJeffryes hmmm maybe I wasn't doing it in a right way. In workspace test, I have to start a service locally. And I download this file to lib. Because Server.py does from biokbase import log

JamesJeffryes commented 5 years ago

Yeah, this is confusing. This file is in like 3 places but the one that get's included in the base SDK image (and thus the one Id recommend for you WS docks) is here: https://github.com/kbase/sdkbase2/blob/python/log.py

Tianhao-Gu commented 5 years ago

@JamesJeffryes ahh thanks. Closing ticket.