Java edits for kb-sdk 1.3

kbase / kb_sdk

Build and test new apps for the KBase platform

http://kbase.github.io/kb_sdk_docs

MIT License

26 stars 32 forks source link

Java edits for kb-sdk 1.3 #350

Closed ialarmedalien closed 4 years ago

ialarmedalien commented 4 years ago

Some changes to prepare kb-sdk for generating GitHub actions and updating the default module builds.

The first commit is all whitespace changes -- my editor removes trailing whitespace and turns tabs into spaces, so I committed all the whitespace changes prior to the content changes. I would suggest viewing just the last three commits.

The changes in this PR comprise:

adding a build date stamp to kb-sdk version
cleaning up some commented-out lines in the Module Builder
added in some extra feedback to alert users as to whether auth is using an environment variable or an auth token in a file
added in a GitHub action that does some rudimentary checks of kb-sdk functioning, in lieu of having proper tests.

ialarmedalien commented 4 years ago

GitHub Actions results for commit 9ac1aba: https://github.com/ialarmedalien/kb_sdk/actions/runs/137434654

MrCreosote commented 4 years ago

Java client generated by kb-sdk uses the correct name for KBase report

This still seems off. The Java client doesn't know about the KBase report at all in general. The generated tests for the java module were using an incorrect class name.

ialarmedalien commented 4 years ago

Java client generated by kb-sdk uses the correct name for KBase report

This still seems off. The Java client doesn't know about the KBase report at all in general. The generated tests for the java module were using an incorrect class name.

"Corrected a class name in the Java client generated by kb-sdk"?

MrCreosote commented 4 years ago

I would say 'Corrected a class name in the generated tests for the Java SDK module'. It doesn't really have anything to do with the Java client generally.

If you want to be really specific then 'Corrected a class name for the Java KBaseReport client in the generated tests for the Java SDK module'