search

kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
27 stars 32 forks source link

Remove outdated sdkbase directory and docs #353

Closed ialarmedalien closed 4 years ago

ialarmedalien commented 4 years ago

The sdkbase directory is no longer used as new KBase apps are built on sdkbase2. This PR removes the old sdkbase directory and mentions of it in the documentation.

Closes https://github.com/kbase/kb_sdk/issues/351.

MrCreosote commented 4 years ago

Where does the SDK base image Dockerfile live these days?

Edit: I guess I have two questions: 1) Where does the Dockerfile for the app base image(s) live 2) Where does the Dockerfile for the dockerized version of kb-sdk live

ialarmedalien commented 4 years ago

@MrCreosote:

  1. The app base images are in https://github.com/kbase/sdkbase2; there are two branches, python, for py3 apps, and master, for perl and java apps (and py2). When you use the SDK to create an app, the dockerfile will be based on one of those two images.
  2. Are you referring to the Dockerfile for kb-sdk itself - i.e. what makes the image that you get if you run docker pull kbase/kb-sdk? If so, it is in this repo: https://github.com/kbase/kb_sdk/blob/develop/Dockerfile
MrCreosote commented 4 years ago

Are you referring to the Dockerfile for kb-sdk itself - i.e. what makes the image that you get if you run docker pull kbase/kb-sdk? If so, it is in this repo: https://github.com/kbase/kb_sdk/blob/develop/Dockerfile

Wait - so dockerized kb-sdk isn't released?

So am I right in thinking that the sdkbase directory is completely unused everywhere, based on the answers above?

ialarmedalien commented 4 years ago

@MrCreosote Yup! The sdkbase directory is unused.

MrCreosote commented 4 years ago

And dockerized kb-sdk isn't released?

ialarmedalien commented 4 years ago

Dockerized kb-sdk is available via docker pull kbase/kb-sdk.

MrCreosote commented 4 years ago

But the dockerfile is on the develop branch, hence not released, right?

ialarmedalien commented 4 years ago

This is the current status of kb-sdk docker images:

https://hub.docker.com/r/kbase/kb-sdk/tags

master (aka latest) has not been updated in 2+ years. The kb-sdk image tagged develop will soon be automatically uploaded every time there's a merge into develop.