Better perl

[ialarmedalien]

Part I of some improvements I made a while back to the perl sdk app templates. I'm using the fully improved perl sdk app for the Jacobson / Cytoscape app (kb_cytoscape).

Commit 1 is almost entirely whitespace changes from running the code formatter perltidy over the codebase.

Commit 2 has more simple changes, including:

• some more perltidy tidy up
• adding use strict and use warnings to all files so errors get reported
• use the correct form of class initialisation, which is Class::Name->new, not new Class::Name
• removed $PATH from the $PERL5LIB env var -- $PATH is for executables, $PERL5LIB is for libraries
• a few minor variable renamings

Note: the tests are marked as failed because this is from my own forked repo. They have passed on my repo: https://github.com/ialarmedalien/kb_sdk/tree/better_perl (note little green tick).

[MrCreosote]

Sorry, I don't understand why the tests would fail in your repo but pass here...? Is it due to secrets not working on PRs?

[ialarmedalien]

@MrCreosote yes, exactly.

[MrCreosote]

I'm still working on it. There's just a lot of changes and I've had a lot of meetings the past couple days.