kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
26 stars 32 forks source link

Remove return statement that stops kb-sdk test #357

Closed ialarmedalien closed 4 years ago

ialarmedalien commented 4 years ago

Currently, if you run kb-sdk test for the first time, it will exit after creating the test.cfg configuration file. However, since kb-sdk can now extract dev tokens from the environment (specifically from the env var KBASE_TEST_TOKEN), it is possible for the test run to go ahead as test.cfg and the environment may contain all the information needed to run the tests. If there is no token in the environment or test.cfg, kb-sdk test will die with the usual message about "Error: KBase account credentials are not set...".

To test this, I have removed the steps from the GitHub actions where test.cfg is edited to add the test token, and just populated the environment variable instead. The tests now run without requiring the extra kb-sdk test || true step.

I have also edited the error message about missing KBase account credentials to state that they were not found in either test.cfg or the env var KBASE_TEST_TOKEN.