kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
26 stars 32 forks source link

Removing "-t" flag to allow github actions to run kb-sdk #362

Closed ialarmedalien closed 3 years ago

ialarmedalien commented 3 years ago

GitHub Actions cannot run kb-sdk when it is in a docker container because the entrypoint script adds the -t flag to the docker command (to add a TTY-type interface to the container), which causes GitHub Actions to error out. Since the commands that the entry point script is adding can't be run interactively, the -t flag can be safely removed.

briehl commented 3 years ago

I had to workaround this on some Github actions stuff by editing the genscript results. This would be great to merge before the next image release.

scanon commented 3 years ago

LGTM

jsfillman commented 3 years ago

This eliminates the need for a custom kb-sdk command, like I've been using in the SDK Tests Action as seen here. Excellent!