kbase / kb_sdk

Build and test new apps for the KBase platform
http://kbase.github.io/kb_sdk_docs
MIT License
26 stars 32 forks source link

Updating Dockerfile to enable `docker buildx` #366

Closed jsfillman closed 1 year ago

jsfillman commented 2 years ago

Summary

This pull request simply updates the docker install line to: apt-get -y install docker-ce docker-ce-cli containerd.io docker-compose-plugin

Justification

As part of DEVOPS-765, we're creating custom workflows for some repos (e.g. sample_service) to run make compile, which triggers the kb-sdk compile step.

The easiest way to make this work is to simply build using the kbase/kb-sdk image vs the stock ubuntu-latest image. Since the custom workflows in question are based on our reusable workflows, they need the ability to build using the docker buildx command.

Testing

jsfillman commented 2 years ago

For clarity, the intent is to:

  1. Update kb-sdk to enable docker buildx.
  2. Add the proposed modified workflows only to repos that need to run kb-sdk compile (via make compile.
  3. Leave the main reusable workflows in kbase/.github as-is for now.