kbase / kbase-ui

kbase-ui components

MIT License

10 stars 22 forks source link

UIP-6 - use KBase standard(ish) GHA workflows #1604

Closed eapearson closed 2 years ago

eapearson commented 2 years ago

Pull Request: UIP-6 - use KBase standard(ish) GHA workflows

Description

Removes existing workflows, adds new workflows based on those from the Sample Service (https://github.com/kbase/sample_service) which were worked on to be compliant with the new KBase standards for service repo workflows.

Having the workflows comply (generally) with the standard workflows will be easier for new developers and devops staff to understand and debug. In addition they will generate uniformly tagged images under uniformly understood conditions.

The only dependencies are the GitHub Actions in implementing the workflows, which can be determined from the source code.

Issues Resolved

https://kbase-jira.atlassian.net/browse/UIP-6
[x] Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
[-] Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

Provide details for testing status and how to test the PR:

[-] Tests pass locally
[-] Tests pass in github actions
[x] Manually verified that changes are available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

[?] Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[-] I have added tests that prove my fix is effective or that my feature works
[-] New and existing unit tests pass locally with my changes
[-] Integration tests have been run and fully pass (only when preparing a release)
[-] I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

[x] Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
[x] Add relevant notes to this document