kbase / kbase-ui

kbase-ui components

MIT License

10 stars 22 forks source link

Small changes in response to integration testing [UIP-5] #1605

Closed eapearson closed 2 years ago

eapearson commented 2 years ago

Pull Request implementing UIP-5

Description

After re-implementing integration tests against kbase-ui and plugins, some small fixes and testability improvements were made, primarily to the dataview plugin.

Issues Resolved

https://kbase-jira.atlassian.net/browse/UIP-5
[x] Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
[-] Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

Provide details for testing status and how to test the PR:

[x] Tests pass locally
[-] Tests pass in github actions
[x] Manually verified that changes area available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

[-] Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[-] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[-] New and existing unit tests pass locally with my changes
[x] Integration tests have been run and fully pass (only when preparing a release)
[-] I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

[x] Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
[x] Add relevant notes to this document

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 2db5f1118a30e78df2c3698f74a17a47c1a4434c into 8893ae6b1e1b841d9c9e207df0119005a3552688 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class