kbase / kbase-ui

kbase-ui components

MIT License

10 stars 22 forks source link

jgi-search: xss cleanup [UIP-12] #1614

Closed eapearson closed 2 years ago

eapearson commented 2 years ago

Pull Request to address UIP-12

Description

Takes care of xss scanning script warnings. No really xss issues, but wrapped calls to innerHTML anyway.

Issues Resolved

https://kbase-jira.atlassian.net/browse/UIP-12

[x] Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
- ] Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

[x] Tests pass locally
[-] Tests pass in github actions
[x] Manually verified that changes area available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

[-] Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[-] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[-] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Integration tests have been run and fully pass (only when preparing a release)
[x] I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

[x] Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
[x] Add relevant notes to this document