eapearson commented 2 years ago

Pull Request

Description

The dataview plugin's provenance viewer suffered a bug in the code which handles the case of more than 50 referencing objects. The code was worked around and removed in two ways:

only one version of an object is rendered; previously all object versions would be included in the graph, which could blow up the # of referencing objects, and make a mess of the graph
the prior solution to > 50 referencing objects was to create a "fake" graph node and link; this is an odd solution - the "fake" node is not a real object and uses invalid information to achieve this, and the user would likely not even notice this fake node. The new solution is to show a warning message.

Issues Resolved

https://kbase-jira.atlassian.net/browse/UFI-19
[x] Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
[-] Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

No existing or new test for this condition

[x] Tests pass locally
[x] Tests pass in github actions
[x] Manually verified that changes area available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

[-] Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[-] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Integration tests have been run and fully pass (only when preparing a release)
[x] I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

[x] Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
[x] Add relevant notes to this document

Release

This section only relevant if this PR is preparing a release

[ ] Bump version in config/release.yml
[ ] Rename release-notes/RELEASE_NOTES_NEXT.md to the appropriate release
[ ] Add release notes document to the release notes index release-notes/index.md

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts when merging 200890a1a2967f80a8c34f0e953d4ad8be8bbf9f into 51bc89d542efe5479410b6c95ca6206380f9381f - view on LGTM.com

new alerts:

1 for Unreachable statement
1 for Expression has no effect
1 for Template syntax in string literal