kbase / kbase-ui

kbase-ui components

MIT License

10 stars 22 forks source link

PTV-1884 #1643

Closed eapearson closed 1 year ago

eapearson commented 1 year ago

Pull Request

Description

Improves the username field in the signup form to use a separate availability lookup to replace the lookup-while-typing which because awkward over slow networks PTV-1884

Issues Resolved

https://kbase-jira.atlassian.net/browse/PTV-1884
[x] Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
[x] Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

Provide details for testing status and how to test the PR:

[x] Tests pass locally
[x] Tests pass in github actions
[x] Manually verified that changes area available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

[ ] Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Integration tests have been run and fully pass (only when preparing a release)
[x] I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

[x] Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
[x] Add relevant notes to this document

Release

This section only relevant if this PR is preparing a release

[ ] Bump version in config/release.yml
[ ] Rename release-notes/RELEASE_NOTES_NEXT.md to the appropriate release
[ ] Add release notes document to the release notes index release-notes/index.md