Add release date prior to merge to master

kbase / relation_engine

Repository containing the KBase Relation Engine API, specs, and other related files.

MIT License

3 stars 11 forks source link

Add release date prior to merge to master #166

Closed MrCreosote closed 2 years ago

MrCreosote commented 2 years ago

Changes have been running in CI since the 5th

[n/a] I updated the README.md docs to reflect this change.

For changes to the codebase:

[n/a] I have written tests to cover this change.
[x] This is not a breaking API change OR
[ ] This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

MrCreosote commented 2 years ago

Why is this its own separate PR?

Which PR were you thinking it should be included in? Neither of the other two I did yesterday seemed appropriate to me

And it's not even in the dev->main PR?

It is though? https://github.com/kbase/relation_engine/pull/167/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR8

n1mus commented 2 years ago

Sorry, ignore what I said. I almost immediately added an "Edit:" to my previous comment, saying that I realized you did this because develop is a protected branch. So you have to PR any random stuff in.

MrCreosote commented 2 years ago

I never push directly to develop or master for any kbase repos