Small alteration to results structure

kbase / relation_engine

Repository containing the KBase Relation Engine API, specs, and other related files.

MIT License

3 stars 11 forks source link

Small alteration to results structure #43

Closed ialarmedalien closed 4 years ago

ialarmedalien commented 4 years ago

[x] I updated the README.md docs to reflect this change.
[x] This is not a breaking API change OR

jayrbolton commented 4 years ago

How/where is this "coerce" property used and what is its purpose? I'm having a hard time finding anything.

jayrbolton commented 4 years ago

Test failure might be intermittent? Re-running tests. Happy to merge this, but also would like to know more what's going on

jayrbolton commented 4 years ago

Something very funky is going on with gunicorn in the tests on github

ialarmedalien commented 4 years ago

I'm using the "coerce" property in another set of tests that are running off the same file.

The test failure issue seems to be due to a new release of greenlet, which has changed the size of the binary:

/usr/local/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 152, got 144

I've pinned the greenlet version to the previous version in the dependencies as a temporary fix.

jayrbolton commented 4 years ago

Another test in a different repo? Because I don't see the "coerce" property being used anywhere here.

ialarmedalien commented 4 years ago

yes, in the kb_cytoscape app repo. Sorry, should have been clearer!