adding script for auto-generating yaml files for ontology loading

kbase / relation_engine

Repository containing the KBase Relation Engine API, specs, and other related files.

MIT License

3 stars 11 forks source link

adding script for auto-generating yaml files for ontology loading #83

Closed zhlu9890 closed 3 years ago

zhlu9890 commented 3 years ago

[ ] I updated the README.md docs to reflect this change.

For changes to the codebase:

[ ] I have written tests to cover this change.
[X] This is not a breaking API change OR
[ ] This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

scanon commented 3 years ago

This is a good start. I think we need a few things.

Some unit tests for the generation script. It could start simple and we could build out.
Documentation. This should clarify the steps to add an ontology.
I think the script could use some additional documentation too.

zhlu9890 commented 3 years ago

I added some tests and update the scripts as suggested. As Shane said, it would be running interactively in command line, so I didn't add much error handling but added warning and error msg to help user to find potential problems (most likely due to path privilege which user could fix accordingly).