kbase / shock_java_client

Basic java client for Shock.
MIT License
0 stars 2 forks source link

Update client for blobstore compatibility. #21

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Next PR will add content length for the uploaded file.

sychan commented 5 years ago

Are you throwing an error if they submit index or attribute information? I saw that you stripped out the support for it, but if it silently ignores stuff, that isn't great.

MrCreosote commented 5 years ago

@sychan They can't submit or retrieve attrib info anymore, those methods are gone. The only support the client ever offered for indexes was that on a copy it'd tell shock to copy the indexes. Now it doesn't tell shock to do that. AFAIK KBase doen't use indexes and the blobstore won't support indexes so I think this is moot anyway.