search

kbase / staging_service

MIT License
0 stars 9 forks source link

Return file prefix and suffix #114

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

Use is twofold: 1) Allow the client programmer to understand what suffix was used to compute the importer mappings 2) Allow the client programmer to easily generate a new name based off the original filename without the suffix for any derived data products.

bio-boris commented 3 years ago

Can also put in a fix for https://github.com/kbase/staging_service/issues/105 as well, just delete the print statement

MrCreosote commented 3 years ago

Do we want that printout for the regular server startup though? When I made that ticket I really didn't know anything about the staging service.

bio-boris commented 3 years ago

I added it to help figure out /debug where the configs were coming from, could always add it back when necessary.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MrCreosote commented 3 years ago

@bio-boris since you did approve, I'm going to go ahead and merge this and work on a new PRs for the things we've discussed so far. If you want to keep discussing some of the issues above here or on Slack that'd be great - particularly anything that would change the api