kbase / staging_service

MIT License
0 stars 9 forks source link

Update to python 3.9 #122

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

Needed to update a few libraries for compatibility

Also minor simplifications to a test fixture

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 1b1560b3e951316f4e971e0339d187275c3fa611 into 19abc6b84df9a8b796ca17fa2bfafcbe39fdfe77 - view on LGTM.com

new alerts:

MrCreosote commented 3 years ago

LGTM is complaining about files this PR doesn't touch

bio-boris commented 3 years ago

Might as well upgrade it to 3.9, it works for me for FROM python:3.9

MrCreosote commented 3 years ago

I did 3.8 because 3.9 isn't in apt for my distribution yet, and the features I want are in 3.7. If I need 3.9 I'll go through the hassle of installing a ppa then

bio-boris commented 3 years ago

I'm in favor of taking it all the way to 3.9 if we are upgrading python. It shouldn't take more than a few minutes to install miniconda for 3.9, setup a virtualenv and install requirements.txt, or to just use the python in the docker container. I don't think we have any policy on upgrading services based on using python versions with the latest EOL vs developer convenience, but otherwise the PR looks fine and deployed to CI

MrCreosote commented 3 years ago

I wouldn't touch *conda if you served it to me on a skewer with hollandaise sauce. Several times bitten, several times shy

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MrCreosote commented 3 years ago

Turns out I need features in 3.9 as well, so you get your wish

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 9774dd2e265ce12e6d6eb83d4b000b3e338bc2a7 into 19bdd194e8e3eeaccc478423d3354661256c342e - view on LGTM.com

new alerts: