search

kbase / staging_service

MIT License
0 stars 9 forks source link

DATAUP-549: Add column count to the xSV header #137

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

This will be required to properly handle Excel files, where pandas autopads willy nilly

Also adds a few more code changes for excel readiness so that that PR will be less nasty

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

MrCreosote commented 3 years ago

At some point I would like to test this out with some actual xSV files and discover what kind of errors are not obvious.

yeah, I definitely want to do some user testing within the team as well as outside it.

MrCreosote commented 3 years ago

Since you approved I'm going to merge and put up the next PR, but happy to continue the discussion here.