search

kbase / staging_service

MIT License
0 stars 9 forks source link

Remove app names from file mapping configuration #170

Open MrCreosote opened 2 years ago

MrCreosote commented 2 years ago

Narrative now specifies the app names and so the entries in the staging service are cruft

E.g this dict should no longer be needed: https://github.com/kbase/staging_service/blob/master/staging_service/autodetect/GenerateMappings.py#L32

Note this is a backward incompatible change, so be sure that anyone currently using endpoints that return these names aren't depending on them. I believe this is the case, but double checking is good.

bio-boris commented 2 years ago

The narrative ignores these as of https://github.com/kbase/narrative/pull/2658 I believe