kbase / staging_service

MIT License
0 stars 9 forks source link

PTV-1866: Deal with NaN and Inf values correctly and consistently #183

Closed MrCreosote closed 1 year ago

MrCreosote commented 1 year ago

If an xSV file had nan as an entry, the server would return JSON with nan as a bareword, causing some JSON parsers (including JS) to choke. This PR does two things:

  1. Returns any NaN or Inf values as strings in the xSV parser
  2. Update the Excel parser to behave in equivalent ways by not treating NaN or Inf as missing values.
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication