DATAUP-236 Importer mapping - Githubissues

kbase / staging_service

MIT License

0 stars 9 forks source link

DATAUP-236 Importer mapping #87

Closed bio-boris closed 4 years ago

bio-boris commented 4 years ago

Summary: This pr adds an endpoint that returns a list of apps and a mapping for each filename you pass in.

To review it,

start by checking the box to ignore whitespace
ignore the files that are simply linted by black

The files to review for generating the mappings are

supported_apps_w_extensions.json
GenerateMappings.py
Mappings.py

The files to review for calling the API endpoint and the lookup for each file type are

app.py (See new endpoint called importer_mappings)
AutoDetectUtils.py AutoDetectUtils.py

The files to review for running a test are

tests/test_app.py
tests/test_autodetect.py

The business logic to review is

The documentation to review is

README.md
TODO documentation on setting up test.env to run_tests.sh

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 0bca572e369aa67739624295e4c1667905112474 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Unused import
1 for Syntax error

lgtm-com[bot] commented 4 years ago

This pull request introduces 5 alerts when merging abcc2ace951ee3f6518e9d8c79780cffd3afa324 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

2 for Unused import
2 for Redundant assignment
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 6 alerts when merging 8b22680600e8a4459f994865b74d47599482223f into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

2 for Unused import
1 for Use of the return value of a procedure
1 for Implicit string concatenation in a list
1 for Variable defined multiple times
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging ec1d6aa9f9ff8bfaa53768f8d906a90708f89bb3 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 86b376a71f727e2edac41ba6f65e5ed140a346d4 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 8d848726a7a4291964d1aee6932b602e7cd11cb1 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging c37b04b9689fef8788c255337edb246ae4cafa16 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging dc26aa06ff106beedbe27cbece36aa5e63648153 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 808b2d09086d6d1561b4e84e7421127dcff71ff4 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging b5c716393eb6f1b308ab494c5c7a53d6d757e253 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 8521a896df182d7c44ad619a1b4c44ea483f8562 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 028e5fd605f4fd080833573e0b85f7a838d35a72 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging fddd94926e36dcfd5dcfc53b940d55cfae483164 into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging ec149dac8e5f0abf10be714578bd74a48092ca1f into 33068fdf2b271e9de295d3712fd98a7d7738520c - view on LGTM.com

new alerts:

1 for Variable defined multiple times

sonarcloud[bot] commented 4 years ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 2 Security Hotspots to review)
61 Code Smells

No Coverage information
6.1% Duplication