search

kbase / workspace_deluxe

The Workspace Service (WSS) is primarily a language independent remote storage and retrieval system for KBase typed objects (TO) defined with the KBase Interface Description Language (KIDL).
MIT License
1 stars 17 forks source link

Remove JNA #723

Closed MrCreosote closed 6 months ago

MrCreosote commented 6 months ago

JNA doesn't work in a shadow jar, which we'll need for workspace test rigs in other repos

codecov[bot] commented 6 months ago

Codecov Report

Merging #723 (23a2657) into dev-gradle2 (6fdb23b) will decrease coverage by 0.01%. Report is 1 commits behind head on dev-gradle2. The diff coverage is 60.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-gradle2 #723 +/- ## ================================================= - Coverage 87.74% 87.74% -0.01% - Complexity 5329 5330 +1 ================================================= Files 228 228 Lines 17631 17635 +4 Branches 2570 2569 -1 ================================================= + Hits 15471 15473 +2 - Misses 1697 1700 +3 + Partials 463 462 -1 ```
Xiangs18 commented 6 months ago

I am not that familiar with syslog4j. Is it similar to Log4j?

MrCreosote commented 6 months ago

No, it's used for sending log information to the linux syslog daemon as opposed to being a logging framework like log4j or slf4j

Xiangs18 commented 6 months ago

Could you please explain more? Still try to understand why a simple logging framework like log4j is not in favor here.

MrCreosote commented 6 months ago

The system has a logging framework - it uses slf4j. slf4j does not provide code for logging to the syslog daemon. Syslog4j does, and so it was used as that was the requirement at the time