kbase / workspace_deluxe

The Workspace Service (WSS) is primarily a language independent remote storage and retrieval system for KBase typed objects (TO) defined with the KBase Interface Description Language (KIDL).
MIT License
1 stars 17 forks source link

Add shadow jar and workspace controller that starts said jar #726

Closed MrCreosote closed 6 months ago

MrCreosote commented 6 months ago

Tested this setup in the Groups service, replacing the workspace controller there

codecov[bot] commented 6 months ago

Codecov Report

Merging #726 (2c17333) into dev-gradle2 (5d9b354) will not change coverage. Report is 3 commits behind head on dev-gradle2. The diff coverage is n/a.

:exclamation: Current head 2c17333 differs from pull request most recent head ed37ddc. Consider uploading reports for the commit ed37ddc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-gradle2 #726 +/- ## ============================================== Coverage 87.74% 87.74% Complexity 5330 5330 ============================================== Files 228 228 Lines 17635 17635 Branches 2569 2569 ============================================== Hits 15473 15473 Misses 1700 1700 Partials 462 462 ```
MrCreosote commented 6 months ago

WorkspaceController can then be invoked to stand up a temporary Workspace service to... do stuff? Does it run its own tests? Does that shadow jar get included with other Java-based services to run a temporary workspace a little more seamlessly than running, say, a Docker image?

It's for cases like this: https://github.com/kbase/groups/blob/master/src/us/kbase/test/groups/integration/ServiceIntegrationTest.java#L124-L132

With the shadowjar, you no longer need to list all the dependent jars: https://github.com/kbase/groups/blob/master/src/us/kbase/test/groups/controllers/workspace/wsjars

So you just add that one jar to your classpath and can easily start up a workspace to test against.

Eventually I want the workspace repo to publish the shadow jar via jitpack but that's a bit farther down the road

MrCreosote commented 6 months ago

which is kinda awesome.

and it's totally awesome, thank you very much