search

kbase / workspace_deluxe

The Workspace Service (WSS) is primarily a language independent remote storage and retrieval system for KBase typed objects (TO) defined with the KBase Interface Description Language (KIDL).
MIT License
1 stars 17 forks source link

Add schema updater script build #731

Closed MrCreosote closed 7 months ago

MrCreosote commented 7 months ago

Tested with -h

ialarmedalien commented 7 months ago

What do you mean by "tested with -h"? Isn't this a short enough task that you can just test it by running it, or am I missing some important context?

codecov[bot] commented 7 months ago

Codecov Report

Merging #731 (a4f5350) into dev-gradle2 (d6f4fcb) will not change coverage. Report is 6 commits behind head on dev-gradle2. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-gradle2 #731 +/- ## ============================================== Coverage 87.77% 87.77% Complexity 5332 5332 ============================================== Files 228 228 Lines 17635 17635 Branches 2589 2589 ============================================== Hits 15479 15479 Misses 1698 1698 Partials 458 458 ```
MrCreosote commented 7 months ago

What do you mean by "tested with -h"? Isn't this a short enough task that you can just test it by running it, or am I missing some important context?

I mean I tested it by running update_workspace_database_schema -h after the build and making sure the java code ran

ialarmedalien commented 7 months ago

Ah, OK -- sorry, I thought you were talking about running the gradle task!

MrCreosote commented 7 months ago

No worries, was clearly a lack of explicitness on my part