Add a workspace client module

kbase / workspace_deluxe

The Workspace Service (WSS) is primarily a language independent remote storage and retrieval system for KBase typed objects (TO) defined with the KBase Interface Description Language (KIDL).

MIT License

1 stars 17 forks source link

Add a workspace client module #738

Closed MrCreosote closed 5 months ago

MrCreosote commented 5 months ago

The purpose of this module is to allow for serving the workspace client jar out of jitpack.io, which can only serve 1 jar per module.

I figured this approach was better than making a separate repo and having to sync over the spec, make sure the github releases were equivalent & up to date, etc.

The drawback is the duplicate generated code, but a 2nd repo would have that drawback as well.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.78%. Comparing base (d3e894d) to head (b55a0eb). Report is 13 commits behind head on dev-gradle2.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev-gradle2 #738 +/- ## ============================================== Coverage 87.78% 87.78% Complexity 5328 5328 ============================================== Files 228 228 Lines 17598 17598 Branches 2585 2585 ============================================== Hits 15448 15448 Misses 1694 1694 Partials 456 456 ```

Xiangs18 commented 5 months ago

how to make sure generated code is up to date?

MrCreosote commented 5 months ago

./gradlew sdkCompile compiles the generated code for both the client and server subprojects

MrCreosote commented 5 months ago

It's 100% clunky. It's just the least clunky option I'm aware of

ialarmedalien commented 5 months ago

When ya gotta clunk, ya gotta clunk.