search

kbaseapps / DataFileUtil

MIT License
0 stars 12 forks source link

Fix build and tests #98

Closed MrCreosote closed 7 months ago

MrCreosote commented 7 months ago

Google downloads seem to work now anyway, given up to date urls retrieved from google drive. The lesson to be learned here is use libraries rather than fragile string parsing. To that end, we should probably use an actual Google drive client rather than the hack I've got working for now

Also stop running tests twice, which has been happening for 4 years apparently

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.53%. Comparing base (b640d1c) to head (3886f57). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #98 +/- ## ========================================== + Coverage 70.89% 71.53% +0.63% ========================================== Files 5 5 Lines 1182 1212 +30 ========================================== + Hits 838 867 +29 - Misses 344 345 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MrCreosote commented 7 months ago

The coverage report seems to have multiple prior PRs included, as there are changes not included in this PR. For some reason this repo was deactivated in codecov