search

kbaseapps / GenomeFileUtil

MIT License
0 stars 16 forks source link

Fixed false ontology_ref requirment #186

Closed jkbaumohl closed 3 years ago

jayrbolton commented 3 years ago

It looks like I have powers to merge this now without the other two reviewers doing a review. Before I do so, @jkbaumohl can you increment the patch version in kbase.yml? And also add a short note in the changelog about this fix. Then we can deploy to CI at some point.

codecov[bot] commented 3 years ago

Codecov Report

Merging #186 into master will decrease coverage by 0.07%. The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   73.97%   73.89%   -0.08%     
==========================================
  Files          11       11              
  Lines        2866     2873       +7     
==========================================
+ Hits         2120     2123       +3     
- Misses        746      750       +4
Impacted Files Coverage Δ
lib/GenomeFileUtil/core/GenbankToGenome.py 93.48% <33.33%> (-0.68%) :arrow_down:
lib/GenomeFileUtil/core/GenomeInterface.py 79.79% <100.00%> (+0.42%) :arrow_up:
lib/GenomeFileUtil/GenomeFileUtilImpl.py 67.59% <0.00%> (-0.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d6bbe5...af699da. Read the comment docs.

dcchivian commented 3 years ago

will register this v0.11.2 up to beta on CI and up to dev on APPDEV/PROD. will require additional testing before release of module.