search

kbaseapps / kb_gtdbtk

GTDB-Tk App
MIT License
4 stars 9 forks source link

update GTDB-Tk to v2.1.0 and Refdata to R07-RS207 #73

Closed dcchivian closed 2 years ago

dcchivian commented 2 years ago

code change looks good to me. But I think tests can be improved to inspect that accurate reports are generated. Also, can you add GitHub action tests? https://github.com/kbaseapps/kb_sdk_actions

we can't add Github Actions tests because memory required for GTDB-Tk greatly exceeds capacity of nodes where Github Actions tests run. we can only run unit tests on dev1

dcchivian commented 2 years ago

would also like to restore shock tests that we can via DFU, but we can do that work in a later iteration. merging so @Tianhao-Gu can branch from develop to make his updates.