sample_uploader client is hardcoded to beta - Githubissues

kbaseapps / kb_staging_exporter

MIT License

0 stars 3 forks source link

sample_uploader client is hardcoded to beta #35

Open MrCreosote opened 2 months ago

MrCreosote commented 2 months ago

https://github.com/kbaseapps/kb_staging_exporter/blob/333975ed017749775fe8321a99a9d8a3bb6c6494/lib/kb_staging_exporter/Utils/staging_downloader.py#L338

The sample_uploader module is 1.1.2 in beta, 1.1.1 in release in both CI and prod so just switching blindly is not a good idea.

What needs to happen:

sample_uploader needs to go through the release process with a dev who understand the changes
this repo needs to be updated and go through the release process

MrCreosote commented 2 months ago

One wrinkle is that the sample related code has no tests.

https://app.codecov.io/gh/kbaseapps/kb_staging_exporter/blob/master/lib%2Fkb_staging_exporter%2FUtils%2Fstaging_downloader.py#L247